output containing null bytes is truncated in curl

output containing null bytes is truncated in curl_write()

Bug #22031	output containing null bytes is truncated in curl_write()
Submitted:	2003-02-03 10:17 UTC	Modified:	2003-02-03 14:56 UTC
From:	radu dot rendec at ines dot ro	Assigned:
Status:	Closed	Package:	cURL related
PHP Version:	4.3.0	OS:	any
Private report:	No	CVE-ID:	None

[2003-02-03 10:17 UTC] radu dot rendec at ines dot ro

It looks like there is a bug in the curl_write() function of ext/curl/curl.c:

In the case PHP_CURL_STDOUT (line 337), PUTS() is used. A buffer containing null bytes will be echoed up to the first null byte (which will be interpreted as a null terminator by puts), and the rest will be discarded, regardless of 'size' and 'nmemb'.

I suggest using PHPWRITE(data, length) instead of PUTS(data). This ensures that the whole buffer is echoed, even if it contains null bytes.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2003-02-03 14:56 UTC] iliaa@php.net

This bug has been fixed in CVS.

In case this was a PHP problem, snapshots of the sources are packaged
every three hours; this change will be in the next snapshot. You can
grab the snapshot at http://snaps.php.net/.
 
In case this was a documentation problem, the fix will show up soon at
http://www.php.net/manual/.

In case this was a PHP.net website problem, the change will show
up on the PHP.net site and on the mirror sites in short time.
 
Thank you for the report, and for helping us make PHP better.