Very important constant (REC_VERSION) is absent!!!

Bug #23887

Submitted:

2003-05-30 03:22 UTC

Modified:

2003-06-14 13:29 UTC

Votes:	1
Avg. Score:	4.0 ± 0.0
Reproduced:	1 of 1 (100.0%)
Same Version:	1 (100.0%)
Same OS:	0 (0.0%)

From:

igor at gelios dot net

Assigned:

daniela (profile)

Status:

Closed

Package:

InterBase related

PHP Version:

4.3.2

OS:

Any

Private report:

CVE-ID:

None

[2003-05-30 03:22 UTC] igor at gelios dot net

Constant isc_tpb_rec_version is very important and uses with isc_tpb_read_committed constant in transaction parameters.

But interbase.c in php source tree does not define this constant and (!!!) there is no way to use this constant without interbase.c editing/recompiling. 

It's very simple correction!! Please!

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2003-05-30 03:27 UTC] derick@php.net

Please provide a patch if you have the fix.

Derick

[2003-06-05 00:58 UTC] sniper@php.net

We'd like to have the "very simple correction", can you
provide a patch please?

[2003-06-05 01:10 UTC] igor at gelios dot net

Well, i use this corrections:

diff -Naur -x interbase.o -x interbase.lo ext/interbase.original/interbase.c ext/interbase/interbase.c
--- ext/interbase.original/interbase.c  2003-05-31 23:08:58.000000000 +0400
+++ ext/interbase/interbase.c   2003-06-01 00:14:13.000000000 +0400
@@ -554,6 +554,7 @@
        REGISTER_LONG_CONSTANT("IBASE_TIMESTAMP", PHP_IBASE_TIMESTAMP, CONST_PERSISTENT);
        REGISTER_LONG_CONSTANT("IBASE_DATE", PHP_IBASE_DATE, CONST_PERSISTENT);
        REGISTER_LONG_CONSTANT("IBASE_TIME", PHP_IBASE_TIME, CONST_PERSISTENT);
+       REGISTER_LONG_CONSTANT("IBASE_REC_VERSION", PHP_IBASE_REC_VERSION, CONST_PERSISTENT);
        
        return SUCCESS;
 }
@@ -1549,6 +1550,10 @@
                /* isolation level */
                if (trans_argl & PHP_IBASE_COMMITTED) {
                        tpb[tpb_len++] = isc_tpb_read_committed;
+                       
+                       if (trans_argl & PHP_IBASE_REC_VERSION)
+                           tpb[tpb_len++] = isc_tpb_rec_version;
+                       
                } else if (trans_argl & PHP_IBASE_CONSISTENCY)
                        tpb[tpb_len++] = isc_tpb_consistency;
                else 
diff -Naur -x interbase.o -x interbase.lo ext/interbase.original/php_interbase.h ext/interbase/php_interbase.h
--- ext/interbase.original/php_interbase.h      2003-05-31 23:09:10.000000000 +0400
+++ ext/interbase/php_interbase.h       2003-06-01 00:13:00.000000000 +0400
@@ -169,7 +169,8 @@
        PHP_IBASE_NOWAIT = 32,
        PHP_IBASE_TIMESTAMP = 64,
        PHP_IBASE_DATE = 128,
-       PHP_IBASE_TIME = 256
+       PHP_IBASE_TIME = 256,
+       PHP_IBASE_REC_VERSION = 512
 };
 
 #ifdef ZTS

[2003-06-05 04:12 UTC] daniela@php.net

I have no time rigth now 
but I 'll have a look asap.

Assigned to me.

[2003-06-14 13:29 UTC] daniela@php.net

This bug has been fixed in CVS.

In case this was a PHP problem, snapshots of the sources are packaged
every three hours; this change will be in the next snapshot. You can
grab the snapshot at http://snaps.php.net/.
 
In case this was a documentation problem, the fix will show up soon at
http://www.php.net/manual/.

In case this was a PHP.net website problem, the change will show
up on the PHP.net site and on the mirror sites in short time.
 
Thank you for the report, and for helping us make PHP better.