allow colons in time zone offset to strtotime()

Request #26090	allow colons in time zone offset to strtotime()
Submitted:	2003-11-03 00:29 UTC	Modified:	2005-06-28 23:23 UTC
From:	danielc at analysisandsolutions dot com	Assigned:
Status:	Closed	Package:	Feature/Change Request
PHP Version:	5.0.0b1 (beta1)	OS:	n/a
Private report:	No	CVE-ID:	None

[2003-11-03 00:29 UTC] danielc at analysisandsolutions dot com

Description:
------------
The strtotime() function doesn't allow time zone offsets to contain colons ":" in them.  Colons are included in several offset formmating standards.

Reproduce code:
---------------
$t = '2003-10-28 10:20:30-0800';
echo date('Y-m-d H:i:s T', strtotime($t)) . "\n<br />\n";

$t = '2003-10-28 10:20:30-08:00';
echo date('Y-m-d H:i:s T', strtotime($t)) . "\n";


Expected result:
----------------
2003-10-28 13:20:30 EST
<br />
2003-10-28 13:20:30 EST


Actual result:
--------------
2003-10-28 13:20:30 EST
<br />
1969-12-31 18:59:59 EST

On Windows 2000, the attempt with the colons in the offset produces a negative timestamp, so the beloved "Windows does not support dates prior to midnight" warning arises.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2005-06-28 23:23 UTC] nlopess@php.net

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

Fixed in PHP 5.1.