phpize changes don't check for execute status on shtool

Bug #26168	phpize changes don't check for execute status on shtool
Submitted:	2003-11-07 17:09 UTC	Modified:	2003-11-09 23:32 UTC
From:	robbat2 at gentoo dot org	Assigned:
Status:	Closed	Package:	*Compile Issues
PHP Version:	4.3.4	OS:	Gentoo Linux
Private report:	No	CVE-ID:	None

[2003-11-07 17:09 UTC] robbat2 at gentoo dot org

Description:
------------
phpize as of 4.3.4 does NOT check that $builddir/build/shtool is executable before it tries to run it.

Reproduce code:
---------------
1. unpack any source based php extension (I used turck-mmcache-2.4.6)
2. ensure that your /usr/lib/php/build/shtool does NOT have execute set.
3. in the new dir, run phpize.

Expected result:
----------------
should complete correctly.

phpize should set shtool to be executable before it tries to run it, or at the very least it should check if it is executable.

Actual result:
--------------
you get this error:
/usr/bin/phpize: line 1: /var/tmp/portage/turck-mmcache-2.4.6/work/turck-mmcache-2.4.6/build/shtool: Permission denied
/usr/bin/phpize: line 61: -f: command not found

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2003-11-07 17:13 UTC] robbat2 at gentoo dot org

Patch that fixes phpize:
--- php-4.3.4/./scripts/phpize.in.old   2003-11-07 14:20:41.000000000 -0800
+++ php-4.3.4/./scripts/phpize.in       2003-11-07 14:21:07.000000000 -0800
@@ -57,6 +57,7 @@
 aclocal || exit 1
 autoconf || exit 1
 autoheader || exit 1
+test -x $builddir/build/shtool || chmod +x $builddir/build/shtool
 libtoolize=`$builddir/build/shtool path glibtoolize libtoolize`
 $libtoolize -f -c || exit 1

[2003-11-07 21:21 UTC] robbat2 at gentoo dot org

i do realize that /usr/lib/build/* will have the execute bits set on them if the install-build make target has been used, but the purpose of this patch is to

[2003-11-09 23:32 UTC] iliaa@php.net

This bug has been fixed in CVS.

In case this was a PHP problem, snapshots of the sources are packaged
every three hours; this change will be in the next snapshot. You can
grab the snapshot at http://snaps.php.net/.
 
In case this was a documentation problem, the fix will show up soon at
http://www.php.net/manual/.

In case this was a PHP.net website problem, the change will show
up on the PHP.net site and on the mirror sites in short time.
 
Thank you for the report, and for helping us make PHP better.