ncurses5 has headers in ncurses/ subdir

Bug #26564	ncurses5 has headers in ncurses/ subdir
Submitted:	2003-12-09 12:43 UTC	Modified:	2003-12-09 15:30 UTC
From:	mmokrejs at natur dot cuni dot cz	Assigned:	sniper (profile)
Status:	Closed	Package:	Compile Failure
PHP Version:	4CVS-2003-12-09 (stable)	OS:	solaris 2.6
Private report:	No	CVE-ID:	None

[2003-12-09 12:43 UTC] mmokrejs at natur dot cuni dot cz

Description:
------------
It seems the ncurses support in PHP4 is for old ncurses4. The headers used to be in $prefix/include/ncurses.h for example. Nowadays, they are in $prefix/include/ncurses/ncurses.h.

I believe configure should take care of that.

Reproduce code:
---------------
gcc  -Iext/ncurses/ -I/scratch/php4-200312091230/ext/ncurses/ -DPHP_ATOM_INC -I/scratch/php4-200312091230/include -I/scratch/php4-200312091230/main -I/scratch/php4-200312091230 -I/scratch/php4-200312091230/Zend -I/usr/local/openssl-0.9.6l/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/mysql/include/mysql -I/scratch/php4-200312091230/ext/xml/expat  -D_POSIX_PTHREAD_SEMANTICS -I/scratch/php4-200312091230/TSRM  -O3 -mcpu=v8 -Wa,-xarch=v8plusa -felide-constructors -fno-exceptions -fno-rtti  -c /scratch/php4-200312091230/ext/ncurses/ncurses.c -o ext/ncurses/ncurses.o  && echo > ext/ncurses/ncurses.lo
/scratch/php4-200312091230/ext/ncurses/ncurses.c: In function `zm_startup_ncurses':
/scratch/php4-200312091230/ext/ncurses/ncurses.c:212: `KEY_RESIZE' undeclared (first use in this function)
/scratch/php4-200312091230/ext/ncurses/ncurses.c:212: (Each undeclared identifier is reported only once
/scratch/php4-200312091230/ext/ncurses/ncurses.c:212: for each function it appears in.)
/scratch/php4-200312091230/ext/ncurses/ncurses.c:243: `BUTTON4_PRESSED' undeclared (first use in this function)
/scratch/php4-200312091230/ext/ncurses/ncurses.c:244: `BUTTON4_RELEASED' undeclared (first use in this function)
/scratch/php4-200312091230/ext/ncurses/ncurses.c:245: `BUTTON4_CLICKED' undeclared (first use in this function)
/scratch/php4-200312091230/ext/ncurses/ncurses.c:246: `BUTTON4_DOUBLE_CLICKED' undeclared (first use in this function)
/scratch/php4-200312091230/ext/ncurses/ncurses.c:247: `BUTTON4_TRIPLE_CLICKED' undeclared (first use in this function)
/scratch/php4-200312091230/ext/ncurses/ncurses.c:248: `BUTTON_SHIFT' undeclared (first use in this function)
/scratch/php4-200312091230/ext/ncurses/ncurses.c:249: `BUTTON_CTRL' undeclared (first use in this function)
/scratch/php4-200312091230/ext/ncurses/ncurses.c:250: `BUTTON_ALT' undeclared (first use in this function)
/scratch/php4-200312091230/ext/ncurses/ncurses.c: In function `zm_info_ncurses':
/scratch/php4-200312091230/ext/ncurses/ncurses.c:297: `NCURSES_VERSION' undeclared (first use in this function)
make: *** [ext/ncurses/ncurses.lo] Error 1





Actual result:
--------------
I can fix by adding -I/usr/local/include/ncurses 


gcc  -Iext/ncurses/ -I/usr/local/include/ncurses -I/scratch/php4-200312091230/ext/ncurses/ -DPHP_ATOM_INC -I/scratch/php4-200312091230/include -I/scratch/php4-200312091230/main -I/scratch/php4-200312091230 -I/scratch/php4-200312091230/Zend -I/usr/local/openssl-0.9.6l/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/mysql/include/mysql -I/scratch/php4-200312091230/ext/xml/expat  -D_POSIX_PTHREAD_SEMANTICS -I/scratch/php4-200312091230/TSRM  -O3 -mcpu=v8 -Wa,-xarch=v8plusa -felide-constructors -fno-exceptions -fno-rtti  -c /scratch/php4-200312091230/ext/ncurses/ncurses.c -o ext/ncurses/ncurses.o  && echo > ext/ncurses/ncurses.lo

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2003-12-09 15:30 UTC] sniper@php.net

This bug has been fixed in CVS.

In case this was a PHP problem, snapshots of the sources are packaged
every three hours; this change will be in the next snapshot. You can
grab the snapshot at http://snaps.php.net/.
 
In case this was a documentation problem, the fix will show up soon at
http://www.php.net/manual/.

In case this was a PHP.net website problem, the change will show
up on the PHP.net site and on the mirror sites in short time.
 
Thank you for the report, and for helping us make PHP better.

[2003-12-09 20:59 UTC] daniel dot gorski at develnet dot org

BTW: the current ext/ncurses lacks _a lot_ of protos for (even ) the V4 ncurses. The latestst version of ncurses is 5.3, and its only a matter of diligent time (or probably a generator script time only) to add them to ncurses_fe.c, ncurses_functions.c and php_ncurses_fe.h

Harmut, dear .. please

regards dtg