configure craps out on trivial syntax error

Bug #27849	configure craps out on trivial syntax error
Submitted:	2004-04-03 00:09 UTC	Modified:	2004-04-03 12:15 UTC
From:	douzzer at mega dot nu	Assigned:	derick (profile)
Status:	Closed	Package:	Compile Failure
PHP Version:	5.0.0RC1	OS:	FreeBSD
Private report:	No	CVE-ID:	None

[2004-04-03 00:09 UTC] douzzer at mega dot nu

Description:
------------
line #47725 of configure script as distributed in 5.0.0RC1:

  if test "$ext_shared" = "no" || ! test -e $ext_builddir/config.h.in"; then

this blows up on FreeBSD (though note that I'm running a 4.0 userspace for complicated reasons).

the fix is to change

  || ! test

to

  -o !

That done, I got 5.0.0RC1 up and running and behaving itself.  phpbb2.0.8/mysql4.x is my only app at present, but it's a pretty good workout I figure.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2004-04-03 06:13 UTC] derick@php.net

You should have this same problem with PHP 4.3.6RC1 as the code is the same there. Can you please verify that? I've fixes ready for both versions but I'd like you to confirm that it is broken with 4.3.6RC1 too.

[2004-04-03 12:03 UTC] douzzer at mega dot nu

I'll do ya one better.  I knew I remembered having to fix this once
before, and here's where:

+* diff --context=3 ~/src/web/php/php-4.3.5/configure~ ~/src/web/php/php-4.3.5/configure
*** /homes/douzzer/src/web/php/php-4.3.5/configure~     Thu Mar 25 09:03:34 2004
--- /homes/douzzer/src/web/php/php-4.3.5/configure      Mon Mar 29 00:25:55 2004
***************
*** 47424,47430 ****
  
    done
    
!   if test "$ext_shared" = "no" || ! test -e "$ext_builddir/config.h.in"; then
      out="php_config.h"
    else
      out="$abs_builddir/config.h"
--- 47424,47430 ----
  
    done
    
!   if test "$ext_shared" = "no" -o ! -e "$ext_builddir/config.h.in"; then
      out="php_config.h"
    else
      out="$abs_builddir/config.h"

[2004-04-03 12:07 UTC] douzzer at mega dot nu

Oh, and: the problem does <i>not</i> exist in 4.3.4 configure.  It was introduced in 4.3.5.

[2004-04-03 12:15 UTC] derick@php.net

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

Thanks! 

(Though it is not useful to provide patches to configure, as it's generated from config.m4 files)