Home Original page

Fix for bug 33760 breaks build with older curl

Bug #35341 Fix for bug 33760 breaks build with older curl
Submitted: 2005-11-22 22:38 UTC Modified: 2005-11-22 23:54 UTC
From: selsky at columbia dot edu Assigned: mike (profile)
Status: Closed Package: cURL related
PHP Version: 4CVS-2005-11-22 (snap) OS: Solaris
Private report: No CVE-ID: None

 [2005-11-22 22:38 UTC] selsky at columbia dot edu

Description:
------------
I'm build php 4.4.2 snap with a date of 200511222004.  
My configure options are:

./configure \
  --prefix=/opt/php-4.4-dev \
  --sysconfdir=/etc/php \
  --with-config-file-path=/etc/php \
  --with-apxs2-filter \
  --with-openssl=/opt/openssl-0.9.7i \
  --with-curl=/opt/curl-7.11.1

The configure fails to complete.  The failure is in the 
patch added by bug 33760.

Expected result:
----------------
Successful configure run.

Actual result:
--------------
checking for CURL support... yes
checking for cURL 7.9.8 or greater... libcurl 7.11.1
checking for SSL support in libcurl... ./configure: SSL: 
not found
./configure: test: unknown operator ==

curl 7.11.1 supports "--feature" but not "--features".  
Newer versions (7.13.0+) of curl-config support both 
options.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

 [2005-11-22 23:11 UTC] selsky at columbia dot edu

Here's a patch against the PHP_4_4 branch:

$ cvs -q diff -u ext/curl/config.m4
Index: ext/curl/config.m4
========================================================
===========
RCS file: /repository/php-src/ext/curl/config.m4,v
retrieving revision 1.20.2.2.2.1
diff -u -r1.20.2.2.2.1 config.m4
--- ext/curl/config.m4  2 Nov 2005 15:03:36 -0000       
1.20.2.2.2.1
+++ ext/curl/config.m4  22 Nov 2005 22:07:30 -0000
@@ -50,7 +50,7 @@
   fi
   
   AC_MSG_CHECKING([for SSL support in libcurl])
-  CURL_SSL=`$CURL_CONFIG --features | $EGREP SSL`
+  CURL_SSL=`$CURL_CONFIG --feature | $EGREP SSL`
   if test "$CURL_SSL" == "SSL"; then
     AC_MSG_RESULT([yes])
     AC_DEFINE([HAVE_CURL_SSL], [1], [Have cURL with  
SSL support])

 [2005-11-22 23:14 UTC] tony2001@php.net

Apparently your patch cannot fix the problem with "==".

 [2005-11-22 23:25 UTC] selsky at columbia dot edu

My bad.  Both patches are needed.  Your patch fixed the 
bash warnings, but without my patch, configure says 
this:

checking for CURL support... yes
checking for cURL 7.9.8 or greater... libcurl 7.11.1
checking for SSL support in libcurl... no
checking for curl_easy_perform in -lcurl... yes
checking for curl_version_info in -lcurl... yes

However, my curl is built with SSL.

$ curl-config --feature
SSL
IPv6
libz

Thanks for your time.

 [2005-11-22 23:37 UTC] selsky at columbia dot edu

With the "--feature" change, configure correctly reports 
the following:

checking for CURL support... yes
checking for cURL 7.9.8 or greater... libcurl 7.11.1
checking for SSL support in libcurl... yes
checking for SSL library used... openssl
checking openssl/crypto.h usability... no
checking openssl/crypto.h presence... no
checking for openssl/crypto.h... no
checking for curl_easy_perform in -lcurl... yes
checking for curl_version_info in -lcurl... yes

 [2005-11-22 23:54 UTC] tony2001@php.net

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.