[2006-11-28 17:48 UTC] matteo at beccati dot com

Description:
------------
While toying with the pgsql extesion I found that the  pgsql_notify struct is not freed as pointed out in the PostgreSQL documentation: "After processing a PGnotify object returned by PQnotifies, be sure to free it with PQfreemem." (see: http://www.postgresql.org/docs/8.1/interactive/libpq-notify.html ). This could lead to memory leaks as far as I can see.

Reproduce code:
---------------
Here is the patch:

--- ext/pgsql/pgsql.c   2006-10-06 23:45:10.000000000 +0200
+++ ext/pgsql/pgsql_new.c       2006-11-28 18:21:40.000000000 +0100
@@ -4347,6 +4347,8 @@
                add_assoc_string(return_value, "message", pgsql_notify->relname, 1);
                add_assoc_long(return_value, "pid", pgsql_notify->be_pid);
        }
+
+       PQfreemem(pgsql_notify);
 }
 /* }}} */


BTW, pg_*_bytea functions should use PQfreemem too, even if it is simply a wrapper.

 [2006-11-29 15:47 UTC] iliaa@php.net

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.