safe_read does not initialize errno

Bug #39869	safe_read does not initialize errno
Submitted:	2006-12-18 15:20 UTC	Modified:	2006-12-19 09:18 UTC
From:	michiel at boland dot org	Assigned:	dmitry (profile)
Status:	Closed	Package:	CGI/CLI related
PHP Version:	5.2.0	OS:	Solaris
Private report:	No	CVE-ID:	None

[2006-12-18 15:20 UTC] michiel at boland dot org

Description:
------------
When using PHP in FastCGI mode, PHP has a tendency to once
in a while spin in a tight loop, hogging the cpu.

The fix is to initialize errno to 0 before any call to read()
in the safe_read function in sapi/cgi/fastcgi.c

Reproduce code:
---------------
Not applicable

Expected result:
----------------
n.a.

Actual result:
--------------
n.a.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2006-12-18 17:33 UTC] dmitry@php.net

Could you please provide which "errno" and "ret" values leads php into this loop.

[2006-12-18 18:10 UTC] michiel at boland dot org

If errno is already EINTR before entry into safe_read,
then that function will loop forever if the read() call
returns 0