importNode doesn't preserve attribute namespaces
| Bug #47848 | importNode doesn't preserve attribute namespaces | |||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Submitted: | 2009-03-31 11:29 UTC | Modified: | 2009-12-03 20:21 UTC |
|
||||||||||
| From: | robin2008 at altruists dot org | Assigned: | ||||||||||||
| Status: | Closed | Package: | DOM XML related | |||||||||||
| PHP Version: | 5.2.9 | OS: | Ubuntu | |||||||||||
| Private report: | No | CVE-ID: | None | |||||||||||
[2009-03-31 11:29 UTC] robin2008 at altruists dot org
Description:
------------
I was expecting importNode to preserve attribute namespaces.
It doesn't
Reproduce code:
---------------
<?php
// PHP 5.2.* namespace bug - importNode doesn't preserve attribute namespaces
$aDOM= new DOMDocument();
$aDOM->appendChild($aDOM->createElementNS('http://friend2friend.net/','f2f:a'));
echo 'DOM to add into is '.$aDOM->saveXML().chr(13);
$fromdom= DOMDocument::loadXML('<data xmlns:ai=" http://altruists.org " ai:attr="namespaced" />');
echo 'Dom to import from is'.$fromdom->saveXML().chr(13);
$attr= $fromdom->firstChild->attributes->item(0);
$aDOM->documentElement->appendChild($aDOM->importNode($attr));
echo 'Result is '.$aDOM->saveXML();
// The following script gets round this bug
function importAttrNS($targetNode, $attr)
{ // Last modified 2009-01-26 Imports an attribute without losing the NS, if present
if ($attr->prefix=='') $targetNode->appendChild($targetNode->ownerDocument->importNode($attr));
else $targetNode->setAttributeNS($attr->lookupNamespaceURI($attr->prefix), $attr->prefix.':'.$attr->name, $attr->value);
}
?>
Expected result:
----------------
The imported attribute should keep its namespace.
Actual result:
--------------
The imported attribute becomes unnamespaced.
Patches
Pull Requests
History
AllCommentsChangesGit/SVN commits
[2009-12-03 20:21 UTC] rrichards@php.net
[2013-10-03 20:39 UTC] clyde dot adams at mailismagic dot com