STDOUT losing data with posix_isatty()
| Bug #49819 | STDOUT losing data with posix_isatty() | |||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| Submitted: | 2009-10-09 12:50 UTC | Modified: | 2010-05-18 09:25 UTC |
|
||||||
| From: | cschneid at cschneid dot com | Assigned: | mike (profile) | |||||||
| Status: | Closed | Package: | Streams related | |||||||
| PHP Version: | 5.2, 5.3, 6 | OS: | ||||||||
| Private report: | No | CVE-ID: | None | |||||||
[2009-10-09 12:50 UTC] cschneid at cschneid dot com
Description: ------------ The PHP streams for stdin, stdout and stderr are seekable which results in php_stream_flush() and seek being called on it. For some reason php_stream_flush() fails to actually write the data while still calling seek and resetting the stream position. Suggested solution: - Find out why php_stream_flush() fails and fix it (I don't know enough about it) - Mark (some? all?) stdio streams as PHP_STREAM_FLAG_NO_SEEK in sapi/cli/php_cli.c (see patch) - Mark stdio streams as PHP_STREAM_FLAG_NO_SEEK in ext/standard/php_fopen_wrapper.c Reproduce code: --------------- php -r 'echo "hello1\n"; posix_isatty(STDOUT); echo "hello2\n";' >out; cat out Expected result: ---------------- hello1 hello2 Actual result: -------------- hello2
Patches
Pull Requests
History
AllCommentsChangesGit/SVN commits
[2009-10-09 12:54 UTC] cschneid at cschneid dot com
--- sapi/cli/php_cli.c (revision 289412) +++ sapi/cli/php_cli.c (working copy) @@ -565,6 +565,10 @@ s_err->flags |= PHP_STREAM_FLAG_NO_CLOSE; #endif + s_in->flags |= PHP_STREAM_FLAG_NO_SEEK; + s_out->flags |= PHP_STREAM_FLAG_NO_SEEK; + s_err->flags |= PHP_STREAM_FLAG_NO_SEEK; + s_in_process = s_in; php_stream_to_zval(s_in, zin);[2009-10-11 09:41 UTC] Sjoerd@php.net
[2010-03-09 01:22 UTC] felipe@php.net
-PHP Version: 6SVN-2009-10-09 (SVN) +PHP Version: 5.2, 5.3, 6
[2010-05-18 09:25 UTC] mike@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: mike
[2010-05-18 09:25 UTC] mike@php.net