phpinfo() does not report many Windows SKUs

Bug #69835 phpinfo() does not report many Windows SKUs
Submitted: 2015-06-15 12:28 UTC Modified: 2015-06-18 20:08 UTC
From: wenz@php.net Assigned: ab (profile)
Status: Closed Package: PHP options/info functions
PHP Version: Irrelevant OS: Windows
Private report: No CVE-ID: None

 [2015-06-15 12:28 UTC] wenz@php.net

Description:
------------
According to https://msdn.microsoft.com/en-us/library/windows/desktop/ms724358%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396, GetProductInfo() may return over 80 different SKUs. phpinfo() currently only supports 25 of them. 

I have prepared a patch against 5.5 that adds ~50 more SKUs. The following ones were omitted:
- PRODUCT_SOLUTION_EMBEDDEDSERVER_CORE (0x39), PRODUCT_EMBEDDED (0x41) - listed in the Windows SDK, but not in the link above
- PRODUCT_STARTER_E, PRODUCT_HOME_BASIC_E, PRODUCT_HOME_PREMIUM_E, PRODUCT_PROFESSIONAL_E, PRODUCT_ENTERPRISE_E, PRODUCT_ULTIMATE_E - listed on the URL above as "not supported".
- also, we do not identify a SKU where GetProductInfo returns PRODUCT_UNDEFINED (0x1)

Test script:
---------------
<?php
  phpinfo(INFO_GENERAL);

Expected result:
----------------
On Windows 7 Professional N, output should contain "Professional N edition"

Actual result:
--------------
Edition is not detected

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

 [2015-06-15 13:21 UTC] wenz@php.net

-Assigned To: +Assigned To: ab

 [2015-06-16 10:33 UTC] ab@php.net

Thanks for the patch, gonna merge next days.

 [2015-06-18 20:08 UTC] ab@php.net

-Status: Assigned +Status: Closed