Message 105364 - Python tracker

Message105364

Author	benjamin.peterson
Recipients	Arfrever, benjamin.peterson, ezio.melotti, gregory.p.smith, lemburg, loewis, pitrou, vstinner
Date	2010-05-09.02:31:37
SpamBayes Score	0.00011505296
Marked as misclassified	No
Message-id	<r2q1afaf6161005081931g7221ab3cg9de7c322d73b7844@mail.gmail.com>
In-reply-to	<201005090423.39550.victor.stinner@haypocalc.com>

Content
2010/5/8 STINNER Victor <report@bugs.python.org>: > > STINNER Victor <victor.stinner@haypocalc.com> added the comment: > >> Why does this have no tests? > > The function is trivial. Does it really need tests? What kind of tests? Check that it is equivalent to utf-8 with surrogatesescape then. > > fsencode() is already tested indirectly by test_subprocess, and #8513 will add > new tests. Excuses, excuses!

Content

2010/5/8 STINNER Victor <report@bugs.python.org>:
>
> STINNER Victor <victor.stinner@haypocalc.com> added the comment:
>
>> Why does this have no tests?
>
> The function is trivial. Does it really need tests? What kind of tests?

Check that it is equivalent to utf-8 with surrogatesescape then.

>
> fsencode() is already tested indirectly by test_subprocess, and #8513 will add
> new tests.

Excuses, excuses!

History
Date	User	Action	Args
2010-05-09 02:31:39	benjamin.peterson	set	recipients: + benjamin.peterson, lemburg, loewis, gregory.p.smith, pitrou, vstinner, ezio.melotti, Arfrever
2010-05-09 02:31:38	benjamin.peterson	link	issue8514 messages
2010-05-09 02:31:38	benjamin.peterson	create