Message119862
| Author | georg.brandl |
|---|---|
| Recipients | Christophe Simonis, Garen, amaury.forgeotdarc, arekm, devurandom, doko, eric.araujo, georg.brandl, jreese, lars.gustaebel, leonov, loewis, nicdumz, nikratio, ockham-razor, pitrou, proyvind, rcoyner, thedjatclubrock, vstinner, ysj.ray |
| Date | 2010-10-29.06:54:25 |
| SpamBayes Score | 2.514322e-12 |
| Marked as misclassified | No |
| Message-id | <1288335272.44.0.889723895773.issue6715@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
After applying the patch, it builds fine here and the test suite passes. However, it seems to leak quite a bit -- if I run regrtest with -R::, my system starts swapping heavily after the second run. In lzmamodule, there are lots of API calls that aren't error-checked, e.g. PyDict_SetItemString(filter, "dict_size", PyLong_FromLong((long)lzma_options.dict_size)); General comments: please don't introduce tabs and trailing whitespace in C and Python files, and wrap your lines at 79 characters whenever possible. reST function/class directives need a blank line after the signature. (But don't worry about the markup too much, I'll review the new file anyway after commit.) @pitrou: Why is this marked "Python 3.3"? If the error handling in the C module is corrected, it's in a good enough shape to be committed before 3.2b1, and the remaining bugs ironed out until final. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2010-10-29 06:54:32 | georg.brandl | set | recipients: + georg.brandl, loewis, doko, amaury.forgeotdarc, arekm, lars.gustaebel, pitrou, vstinner, nicdumz, eric.araujo, Christophe Simonis, rcoyner, proyvind, nikratio, leonov, devurandom, Garen, ysj.ray, thedjatclubrock, ockham-razor, jreese |
| 2010-10-29 06:54:32 | georg.brandl | set | messageid: <1288335272.44.0.889723895773.issue6715@psf.upfronthosting.co.za> |
| 2010-10-29 06:54:27 | georg.brandl | link | issue6715 messages |
| 2010-10-29 06:54:25 | georg.brandl | create | |