Message 120940 - Python tracker

Message120940

Author	hfuru
Recipients	hfuru, vstinner
Date	2010-11-11.08:50:32
SpamBayes Score	0.09078732
Marked as misclassified	No
Message-id	<hbf.20101111h223@bombur.uio.no>
In-reply-to	<1289399368.31.0.51116551548.issue10308@psf.upfronthosting.co.za>

Content
STINNER Victor writes: > The following change is useless, it cannot overflow: > - if (n + k > MAXPATHLEN) > + if (k > MAXPATHLEN - n) > k = MAXPATHLEN - n; > > n and k maximum values are MAXPATHLEN (and the maximum value of > MAXPATHLEN is 4096), (...) OK. I could only tell that for n, not for k. But even so it would certainly be an unlikely overflow.

Content

STINNER Victor writes:
> The following change is useless, it cannot overflow:
> -    if (n + k > MAXPATHLEN)
> +    if (k > MAXPATHLEN - n)
>          k = MAXPATHLEN - n;
> 
> n and k maximum values are MAXPATHLEN (and the maximum value of
> MAXPATHLEN is 4096), (...)

OK.  I could only tell that for n, not for k.  But even so it would
certainly be an unlikely overflow.

History
Date	User	Action	Args
2010-11-11 08:50:37	hfuru	set	recipients: + hfuru, vstinner
2010-11-11 08:50:32	hfuru	link	issue10308 messages
2010-11-11 08:50:32	hfuru	create