Message 121062 - Python tracker

Message121062

Author	terry.reedy
Recipients	giampaolo.rodola, hfuru, terry.reedy
Date	2010-11-12.19:31:56
SpamBayes Score	1.1662365e-06
Marked as misclassified	No
Message-id	<1289590332.36.0.347389142952.issue10350@psf.upfronthosting.co.za>
In-reply-to

Content
This stuff is hard to write automated tests for, hence there are none. The patch is mostly straightforward: capture errno with new variable err at point of possible error when intervening calculation is needed before testing the value of errno. This seems like a good idea. There is one relocation of memory freeing and the additions of + if (res >= 0) + break; which I cannot evaluate.

Content

This stuff is hard to write automated tests for, hence there are none.

The patch is mostly straightforward: capture errno with new variable err at point of possible error when intervening calculation is needed before testing the value of errno. This seems like a good idea.

There is one relocation of memory freeing and the additions of
+        if (res >= 0)
+            break;
which I cannot evaluate.

History
Date	User	Action	Args
2010-11-12 19:32:12	terry.reedy	set	recipients: + terry.reedy, hfuru, giampaolo.rodola
2010-11-12 19:32:12	terry.reedy	set	messageid: <1289590332.36.0.347389142952.issue10350@psf.upfronthosting.co.za>
2010-11-12 19:31:56	terry.reedy	link	issue10350 messages
2010-11-12 19:31:56	terry.reedy	create