Message 121815 - Python tracker

Message121815

Author	r.david.murray
Recipients	brunogola, endian, gregory.p.smith, orsenthil, r.david.murray, terry.reedy, yangman
Date	2010-11-20.23:48:13
SpamBayes Score	1.4821477e-14
Marked as misclassified	No
Message-id	<1290296895.51.0.600887388971.issue3709@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for the patch and test. They look good. A doc update is also needed, since the docs are currently written in such a way that buffering the header lines makes the documentation no longer true. Also, send_response_only writes directly to the output stream, it doesn't call send_header. This breaks the buffering. It also means that more test cases are needed, since the added test didn't catch this case.

Content

Thanks for the patch and test.  They look good.

A doc update is also needed, since the docs are currently written in such a way that buffering the header lines makes the documentation no longer true.

Also, send_response_only writes directly to the output stream, it doesn't call send_header.  This breaks the buffering.  It also means that more test cases are needed, since the added test didn't catch this case.

History
Date	User	Action	Args
2010-11-20 23:48:15	r.david.murray	set	recipients: + r.david.murray, terry.reedy, gregory.p.smith, orsenthil, brunogola, yangman, endian
2010-11-20 23:48:15	r.david.murray	set	messageid: <1290296895.51.0.600887388971.issue3709@psf.upfronthosting.co.za>
2010-11-20 23:48:13	r.david.murray	link	issue3709 messages
2010-11-20 23:48:13	r.david.murray	create