Message 121943 - Python tracker

Message121943

Author	orsenthil
Recipients	brunogola, endian, gregory.p.smith, orsenthil, r.david.murray, terry.reedy, yangman
Date	2010-11-21.15:50:44
SpamBayes Score	8.55033e-05
Marked as misclassified	No
Message-id	<20101121154915.GA8671@rubuntu>
In-reply-to	<1290352506.83.0.698055530609.issue3709@psf.upfronthosting.co.za>

Content
On Sun, Nov 21, 2010 at 03:15:06PM +0000, R. David Murray wrote: > Senthil, I didn't clearly express my concern about > send_response_only. It doesn't look to me like, with buffering in > place, that it should write directly, it looks to me like it > should write to the buffer. Correct. Now that I re-looked at the code, keeping your above statement in mind", I tend to agree with you and notice the problem. I think, the headers_buffer should be moved higher up in the class so that it buffer the headers from all these methods which atm write directly to the output stream.

Content

On Sun, Nov 21, 2010 at 03:15:06PM +0000, R. David Murray wrote:
> Senthil, I didn't clearly express my concern about
> send_response_only.  It doesn't look to me like, with buffering in
> place, that it *should* write directly, it looks to me like it
> should write to the buffer.

Correct. Now that I re-looked at the code, keeping your above
statement in mind", I tend to agree with you and notice the problem. I
think, the headers_buffer should be moved higher up in the class so
that it buffer the headers from all these methods which atm write
directly to the output stream.

History
Date	User	Action	Args
2010-11-21 15:50:47	orsenthil	set	recipients: + orsenthil, terry.reedy, gregory.p.smith, brunogola, yangman, r.david.murray, endian
2010-11-21 15:50:45	orsenthil	link	issue3709 messages
2010-11-21 15:50:44	orsenthil	create