Message125056
| Author | georg.brandl |
|---|---|
| Recipients | Alexander.Belopolsky, Trundle, belopolsky, georg.brandl, l0nwlf, ned.deily, sandro.tosi, wsanchez |
| Date | 2011-01-02.14:37:42 |
| SpamBayes Score | 2.4145552e-10 |
| Marked as misclassified | No |
| Message-id | <1293979065.18.0.664196007376.issue8013@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
The patch is wrong: it hardcodes the number of characters that the time string has, but it can be more than 24 if the year is > 9999. (Of course, the check for \n currently in the code is wrong too and must be fixed.) Also, shouldn't the issue be handled as in ctime()? There is a NULL check there, and by just doing that check we wouldn't depend on asctime_r(). |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2011-01-02 14:37:45 | georg.brandl | set | recipients: + georg.brandl, belopolsky, wsanchez, ned.deily, Trundle, sandro.tosi, Alexander.Belopolsky, l0nwlf |
| 2011-01-02 14:37:45 | georg.brandl | set | messageid: <1293979065.18.0.664196007376.issue8013@psf.upfronthosting.co.za> |
| 2011-01-02 14:37:42 | georg.brandl | link | issue8013 messages |
| 2011-01-02 14:37:42 | georg.brandl | create | |