Message 125058 - Python tracker

Message125058

Author	rosslagerwall
Recipients	MrJean1, OG7, georg.brandl, giampaolo.rodola, lucaspmelo, pitrou, rosslagerwall
Date	2011-01-02.14:50:30
SpamBayes Score	0.0013057911
Marked as misclassified	No
Message-id	<1293979834.0.0.400038685712.issue5870@psf.upfronthosting.co.za>
In-reply-to

Content
I think if you look closely at the patch, the fd does not stay open the whole time. It is opened if necessary in _get_handles() with e.g.: elif stdin == DEVNULL: p2cread = self._get_devnull() and then closed in _execute_child() with: if hasattr(self, '_devnull'): os.close(self._devnull) which is executed from __init__(). So I don't think it stays open for eternity :-)

Content

I think if you look closely at the patch, the fd does not stay open the whole time. It is opened if necessary in _get_handles() with e.g.:

elif stdin == DEVNULL:
    p2cread = self._get_devnull()

and then closed in _execute_child() with:

if hasattr(self, '_devnull'):
    os.close(self._devnull)

which is executed from __init__(). So I don't think it stays open for eternity :-)

History
Date	User	Action	Args
2011-01-02 14:50:34	rosslagerwall	set	recipients: + rosslagerwall, georg.brandl, pitrou, giampaolo.rodola, OG7, MrJean1, lucaspmelo
2011-01-02 14:50:33	rosslagerwall	set	messageid: <1293979834.0.0.400038685712.issue5870@psf.upfronthosting.co.za>
2011-01-02 14:50:30	rosslagerwall	link	issue5870 messages
2011-01-02 14:50:30	rosslagerwall	create