Message 129060 - Python tracker

Message129060

Author	ezio.melotti
Recipients	ezio.melotti, jafo, nicdumz, pitrou, rhettinger
Date	2011-02-22.12:24:30
SpamBayes Score	5.697549e-08
Marked as misclassified	No
Message-id	<1298377476.05.0.125942768837.issue10924@psf.upfronthosting.co.za>
In-reply-to

Content
Some buildbots are failing after the commit. Also in the crypt.py module I still see things that according to msg126453 should be fixed already: * more statements on the same line (e.g. "if salt == None: salt = mksalt()"); * the hardcoded salt values instead of string.ascii_letters; According to the PEP8 there shouldn't be any spaces after the '[' and before the ']' (e.g. "method_list = [ METHOD_SHA512, METHOD_SHA256, METHOD_MD5 ]" and in the listcomps) and around the = in the function/method declarations/calls (e.g. "def crypt(word, salt = None):").

Content

Some buildbots are failing after the commit.

Also in the crypt.py module I still see things that according to msg126453 should be fixed already:
 * more statements on the same line (e.g. "if salt == None: salt = mksalt()");
 * the hardcoded salt values instead of string.ascii_letters;

According to the PEP8 there shouldn't be any spaces after the '[' and before the ']' (e.g. "method_list = [ METHOD_SHA512, METHOD_SHA256, METHOD_MD5 ]" and in the listcomps) and around the = in the function/method declarations/calls (e.g. "def crypt(word, salt = None):").

History
Date	User	Action	Args
2011-02-22 12:24:36	ezio.melotti	set	recipients: + ezio.melotti, rhettinger, jafo, pitrou, nicdumz
2011-02-22 12:24:36	ezio.melotti	set	messageid: <1298377476.05.0.125942768837.issue10924@psf.upfronthosting.co.za>
2011-02-22 12:24:30	ezio.melotti	link	issue10924 messages
2011-02-22 12:24:30	ezio.melotti	create