Message 129108 - Python tracker

Message129108

Author	paulos
Recipients	giampaolo.rodola, paulos, r.david.murray
Date	2011-02-22.18:33:39
SpamBayes Score	3.064673e-08
Marked as misclassified	No
Message-id	<1298399620.45.0.164700212287.issue11281@psf.upfronthosting.co.za>
In-reply-to

Content
My first idea was to make the argument a tuple to match socket.create_connection(), but SMTP uses host and port arguments, for consistency it's better havin separate source_ip and source_port arguments. As a side effect, it makes easier to specify only source_port. The submited patch includes tests and updated docstrings; At the smtplib.rst, for example: SMTP(host='', port=0, local_hostname=None[, timeout]) Would be ok to change it like: SMTP(host='', port=0, local_hostname=None[, timeout], source_ip='', source_port=0)

Content

My first idea was to make the argument a tuple to match socket.create_connection(), but SMTP uses host and port arguments, for consistency it's better havin separate source_ip and source_port arguments. As a side effect, it makes easier to specify only source_port. 

The submited patch includes tests and updated docstrings; 

At the smtplib.rst, for example:

SMTP(host='', port=0, local_hostname=None[, timeout])

Would be ok to change it like:

SMTP(host='', port=0, local_hostname=None[, timeout], source_ip='', source_port=0)

History
Date	User	Action	Args
2011-02-22 18:33:40	paulos	set	recipients: + paulos, giampaolo.rodola, r.david.murray
2011-02-22 18:33:40	paulos	set	messageid: <1298399620.45.0.164700212287.issue11281@psf.upfronthosting.co.za>
2011-02-22 18:33:39	paulos	link	issue11281 messages
2011-02-22 18:33:39	paulos	create