Message 129112 - Python tracker

Message129112

Author	giampaolo.rodola
Recipients	giampaolo.rodola, paulos, r.david.murray
Date	2011-02-22.19:12:46
SpamBayes Score	0.0008734959
Marked as misclassified	No
Message-id	<1298401967.65.0.555554394794.issue11281@psf.upfronthosting.co.za>
In-reply-to

Content
We already have 3 places where a tuple is used: socket.socket.bind socket.create_connection http.client.HTTPConnection Changing this notation in smtplib for such a rarely used feature is not worth the effort, imo. Also, I would not add two new SMTP attributes. Passing a tuple to socket.create_connection() is just fine. If you want to know the source address afterwards you can use socket.getsockname(). PS - I modified smtplib.py in meantime. Please update your local copy.

Content

We already have 3 places where a tuple is used:

socket.socket.bind
socket.create_connection
http.client.HTTPConnection

Changing this notation in smtplib for such a rarely used feature is not worth the effort, imo.
Also, I would not add two new SMTP attributes. Passing a tuple to socket.create_connection() is just fine. If you want to know the source address afterwards you can use socket.getsockname().

PS - I modified smtplib.py in meantime. Please update your local copy.

History
Date	User	Action	Args
2011-02-22 19:12:47	giampaolo.rodola	set	recipients: + giampaolo.rodola, r.david.murray, paulos
2011-02-22 19:12:47	giampaolo.rodola	set	messageid: <1298401967.65.0.555554394794.issue11281@psf.upfronthosting.co.za>
2011-02-22 19:12:47	giampaolo.rodola	link	issue11281 messages
2011-02-22 19:12:46	giampaolo.rodola	create