Message 129313 - Python tracker

Message129313

Author	pitrou
Recipients	jonash, pitrou, theller
Date	2011-02-24.21:26:54
SpamBayes Score	6.459854e-05
Marked as misclassified	No
Message-id	<1298582815.12.0.789777486332.issue11258@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for the new patch. Looking again, I wonder if there's a reason the original regexp was so complicated. ldconfig output here has lines such as: libBrokenLocale.so.1 (libc6,x86-64, OS ABI: Linux 2.6.9) => /lib64/libBrokenLocale.so.1 libBrokenLocale.so.1 (libc6, OS ABI: Linux 2.6.9) => /lib/libBrokenLocale.so.1 libBrokenLocale.so (libc6,x86-64, OS ABI: Linux 2.6.9) => /usr/lib64/libBrokenLocale.so libBrokenLocale.so (libc6, OS ABI: Linux 2.6.9) => /usr/lib/libBrokenLocale.so Ideally we would factor out the parsing to a separate private function, and have tests for it.

Content

Thanks for the new patch. Looking again, I wonder if there's a reason the original regexp was so complicated. ldconfig output here has lines such as:

	libBrokenLocale.so.1 (libc6,x86-64, OS ABI: Linux 2.6.9) => /lib64/libBrokenLocale.so.1
	libBrokenLocale.so.1 (libc6, OS ABI: Linux 2.6.9) => /lib/libBrokenLocale.so.1
	libBrokenLocale.so (libc6,x86-64, OS ABI: Linux 2.6.9) => /usr/lib64/libBrokenLocale.so
	libBrokenLocale.so (libc6, OS ABI: Linux 2.6.9) => /usr/lib/libBrokenLocale.so

Ideally we would factor out the parsing to a separate private function, and have tests for it.

History
Date	User	Action	Args
2011-02-24 21:26:55	pitrou	set	recipients: + pitrou, theller, jonash
2011-02-24 21:26:55	pitrou	set	messageid: <1298582815.12.0.789777486332.issue11258@psf.upfronthosting.co.za>
2011-02-24 21:26:54	pitrou	link	issue11258 messages
2011-02-24 21:26:54	pitrou	create