Message129739
| Author | rhettinger |
|---|---|
| Recipients | Retro, brian.curtin, eli.bendersky, eric.araujo, eric.smith, georg.brandl, giampaolo.rodola, ncoghlan, rhettinger, terry.reedy, xuanji, ysj.ray |
| Date | 2011-03-01.03:23:04 |
| SpamBayes Score | 0.001298215 |
| Marked as misclassified | No |
| Message-id | <1298949786.79.0.535408244279.issue10516@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
The patch is fine. Do consider using assertIsNot() in the tests. Then go ahead and apply it. The OverflowError in bytearray.pop() is a bug, please open a separate report for it and make a patch changing it to IndexError. Assign that bug report to me. Go ahead and propose a patch for MutableSequence.clear() implemented with MutableSequence.pop() and catching an IndexError when empty. Thanks for your efforts. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2011-03-01 03:23:06 | rhettinger | set | recipients: + rhettinger, georg.brandl, terry.reedy, ncoghlan, eric.smith, giampaolo.rodola, eric.araujo, Retro, eli.bendersky, brian.curtin, ysj.ray, xuanji |
| 2011-03-01 03:23:06 | rhettinger | set | messageid: <1298949786.79.0.535408244279.issue10516@psf.upfronthosting.co.za> |
| 2011-03-01 03:23:04 | rhettinger | link | issue10516 messages |
| 2011-03-01 03:23:04 | rhettinger | create | |