Message 132902 - Python tracker

Message132902

Author	pitrou
Recipients	alex, dabeaz, eric.araujo, gruszczy, nadeem.vawda, pitrou, r.david.murray, vstinner
Date	2011-04-03.22:41:02
SpamBayes Score	7.088062e-05
Marked as misclassified	No
Message-id	<1301870460.3512.28.camel@localhost.localdomain>
In-reply-to	<1301869729.01.0.184154211485.issue10791@psf.upfronthosting.co.za>

Content
> Nadeem Vawda <nadeem.vawda@gmail.com> added the comment: > > > Is following change in GzipFile class enough: > > > > def read1(self, n): > > return self.read(n) > > > > ? This satisfies TextIOWrapper to run readline correctly. > > Looks good to me. Well, ideally, read1() should satisfy the condition stated in the BufferedIOBase documentation - namely, that it issues at most one read() call on the underlying stream.

Content

> Nadeem Vawda <nadeem.vawda@gmail.com> added the comment:
> 
> > Is following change in GzipFile class enough:
> > 
> >     def read1(self, n):
> >         return self.read(n)
> > 
> > ? This satisfies TextIOWrapper to run readline correctly.
> 
> Looks good to me.

Well, ideally, read1() should satisfy the condition stated in the
BufferedIOBase documentation - namely, that it issues at most one read()
call on the underlying stream.

History
Date	User	Action	Args
2011-04-03 22:41:03	pitrou	set	recipients: + pitrou, vstinner, nadeem.vawda, eric.araujo, alex, r.david.murray, gruszczy, dabeaz
2011-04-03 22:41:02	pitrou	link	issue10791 messages
2011-04-03 22:41:02	pitrou	create