Message 134585 - Python tracker

Message134585

Author	neologix
Recipients	bquinlan, dmalcolm, jnoller, kristjan.jonsson, lukasz.langa, neologix, pitrou, sandro.tosi, ysj.ray
Date	2011-04-27.15:42:28
SpamBayes Score	6.2728163e-06
Marked as misclassified	No
Message-id	<1303918950.18.0.0771320633678.issue10517@psf.upfronthosting.co.za>
In-reply-to

Content
> Thank you. I like this patch, except that _PyGILState_ReInit() should be > declared in the appropriate .h file, not in signalmodule.c. I asked myself this question when writing the patch: what's the convention regarding functions ? Should they always be declared in a header with PyAPI_FUNC, or should this be reserved to functions exported through the API? I've seen a couple external function declarations in several places, so I was wondering (and since this one isn't meant to be exported, I chose the later option).

Content

> Thank you. I like this patch, except that _PyGILState_ReInit() should be
> declared in the appropriate .h file, not in signalmodule.c.

I asked myself this question when writing the patch: what's the convention  regarding functions ? Should they always be declared in a header with PyAPI_FUNC, or should this be reserved to functions exported through the API?
I've seen a couple external function declarations in several places, so I was wondering (and since this one isn't meant to be exported, I chose the later option).

History
Date	User	Action	Args
2011-04-27 15:42:30	neologix	set	recipients: + neologix, bquinlan, pitrou, kristjan.jonsson, jnoller, dmalcolm, sandro.tosi, ysj.ray, lukasz.langa
2011-04-27 15:42:30	neologix	set	messageid: <1303918950.18.0.0771320633678.issue10517@psf.upfronthosting.co.za>
2011-04-27 15:42:28	neologix	link	issue10517 messages
2011-04-27 15:42:28	neologix	create