Message 137370 - Python tracker

Message137370

Author	neologix
Recipients	jcon, nadeem.vawda, neologix, petri.lehtinen, pitrou, rich-noir
Date	2011-05-31.17:04:27
SpamBayes Score	0.0007246519
Marked as misclassified	No
Message-id	<BANLkTinjY4OQ6x4pP7AQMOO8rRcwPhit8g@mail.gmail.com>
In-reply-to	<1306831597.46.0.438111858591.issue12021@psf.upfronthosting.co.za>

Content
> I noticed that RawIOBase.read, TextIOBase.read, etc also accept None as the > argument, treating it as -1. Should this be implemented, too? > That's because of the _PyIO_ConvertSsize_t converter, which silently converts None to -1. There's probably a good reason for doing this in the _io module, but I don't see any reason to do the same thing in the mmap module (apart from being consistent, of course). Antoine? If the patch is fine as-is, I'd like to commit it.

Content

> I noticed that RawIOBase.read, TextIOBase.read, etc also accept None as the
> argument, treating it as -1. Should this be implemented, too?
>

That's because of the _PyIO_ConvertSsize_t converter, which silently
converts None to -1.
There's probably a good reason for doing this in the _io module, but I
don't see any reason to do the same thing in the mmap module (apart
from being consistent, of course).
Antoine?

If the patch is fine as-is, I'd like to commit it.

History
Date	User	Action	Args
2011-05-31 17:04:28	neologix	set	recipients: + neologix, pitrou, nadeem.vawda, jcon, rich-noir, petri.lehtinen
2011-05-31 17:04:27	neologix	link	issue12021 messages
2011-05-31 17:04:27	neologix	create