Message 139397 - Python tracker

Message139397

Author neologix
Recipients greg.ath, neologix, pitrou, vstinner
Date 2011-06-29.07:13:08
SpamBayes Score 1.663041e-05
Marked as misclassified No
Message-id <BANLkTim1fEsWRQB2fxqPh0KeuE+8LZStcw@mail.gmail.com>
In-reply-to <1309286706.17.0.129322185731.issue12352@psf.upfronthosting.co.za>
Content
> Nice work! I also think heap_gc_deadlock_lockless.diff is good, except for Victor's reservation: is it deliberate that you reversed the following two statements in _free_pending_blocks(), compared to the code in free()?
>
> +            self._free(block)
> +            self._allocated_blocks.remove(block)
>

No, it's not deliberate (it shouldn't have any impact since they're
protected by the mutex though).
As for calling _free_pending_blocks() a second time, I'm not sure
that's necessary, I find the code simpler and cleaner that way.
I'll provide a new patch in a couple days (no access to my development
box right now).
History
Date User Action Args
2011-06-29 07:13:09neologixsetrecipients: + neologix, pitrou, vstinner, greg.ath
2011-06-29 07:13:08neologixlinkissue12352 messages
2011-06-29 07:13:08neologixcreate