Message141908
| Author | eric.araujo |
|---|---|
| Recipients | eric.araujo, hynek, petri.lehtinen, tarek |
| Date | 2011-08-11.14:57:22 |
| SpamBayes Score | 5.93039e-06 |
| Marked as misclassified | No |
| Message-id | <1313074643.2.0.819140414967.issue12721@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
I’ll make one change before committing: Lib/test/test_shutil.py:69: if isinstance(path, (list, tuple)): Using a list for path components does not make sense. I have changed a similar helper function in packaging to allow only tuples. Petri: these helper functions are all about convenienve. I would reject a patch for a function just doing open+read, but here I think that doing os.path.join+open+read is worth a function. We use such helpers all the time in packaging tests and it helps reducing boilerplate, without being very hard to understand. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2011-08-11 14:57:23 | eric.araujo | set | recipients: + eric.araujo, tarek, petri.lehtinen, hynek |
| 2011-08-11 14:57:23 | eric.araujo | set | messageid: <1313074643.2.0.819140414967.issue12721@psf.upfronthosting.co.za> |
| 2011-08-11 14:57:22 | eric.araujo | link | issue12721 messages |
| 2011-08-11 14:57:22 | eric.araujo | create | |