Message 142884 - Python tracker

Message142884

Author	pitrou
Recipients	eric.araujo, giampaolo.rodola, janssen, pitrou, simpkins
Date	2011-08-24.13:46:47
SpamBayes Score	2.6825686e-05
Marked as misclassified	No
Message-id	<1314193608.13.0.918183535502.issue12803@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for the patch. This is a generally useful functionality and the patch looks mostly good. I have a couple comments: - in _pwinfo_set(), you need to decref password_bytes when you're finished - you check the password size in _password_callback() but not in _pwinfo_set(), is it expected? is the size limit only meaningful with a callback rather than a predefined password?

Content

Thanks for the patch. This is a generally useful functionality and the patch looks mostly good.
I have a couple comments:

- in _pwinfo_set(), you need to decref password_bytes when you're finished
- you check the password size in _password_callback() but not in _pwinfo_set(), is it expected? is the size limit only meaningful with a callback rather than a predefined password?

History
Date	User	Action	Args
2011-08-24 13:46:48	pitrou	set	recipients: + pitrou, janssen, giampaolo.rodola, eric.araujo, simpkins
2011-08-24 13:46:48	pitrou	set	messageid: <1314193608.13.0.918183535502.issue12803@psf.upfronthosting.co.za>
2011-08-24 13:46:47	pitrou	link	issue12803 messages
2011-08-24 13:46:47	pitrou	create