Message 145688 - Python tracker

Message145688

Author	eric.araujo
Recipients	alexis, eric.araujo, paul.moore, tarek, vinay.sajip
Date	2011-10-17.13:15:11
SpamBayes Score	6.8251865e-10
Marked as misclassified	No
Message-id	<1318857312.51.0.756657160129.issue13175@psf.upfronthosting.co.za>
In-reply-to

Content
> I found the problem - it's in packaging.util.write_record_file. We have two functions that write RECORD files; I’ve opened a report to kill one. > The file passed to csv.writer should be opened with newline=''. How will we port this to 2.x? > I don't expect the test will catch the issue except on Windows... Do you mean that the test will fail or be a no-op on other OSes? We can mark it as Windows-specific (@unittest.skipIf(sys.platform != 'win32', 'test only relevant on win32')) or just let it run if it’s harmless. The important point is: does it fail before the fix, does it pass after?

Content

> I found the problem - it's in packaging.util.write_record_file.
We have two functions that write RECORD files; I’ve opened a report to kill one.

> The file passed to csv.writer should be opened with newline=''.
How will we port this to 2.x?

> I don't expect the test will catch the issue except on Windows...
Do you mean that the test will fail or be a no-op on other OSes?  We can mark it as Windows-specific (@unittest.skipIf(sys.platform != 'win32', 'test only relevant on win32')) or just let it run if it’s harmless.  The important point is: does it fail before the fix, does it pass after?

History
Date	User	Action	Args
2011-10-17 13:15:12	eric.araujo	set	recipients: + eric.araujo, paul.moore, vinay.sajip, tarek, alexis
2011-10-17 13:15:12	eric.araujo	set	messageid: <1318857312.51.0.756657160129.issue13175@psf.upfronthosting.co.za>
2011-10-17 13:15:11	eric.araujo	link	issue13175 messages
2011-10-17 13:15:11	eric.araujo	create