Message 149745 - Python tracker

Message149745

Author	neologix
Recipients	neologix, r.david.murray, sdaoden
Date	2011-12-18.12:01:15
SpamBayes Score	0.00086216786
Marked as misclassified	No
Message-id	<1324209736.5.0.895749858366.issue11867@psf.upfronthosting.co.za>
In-reply-to

Content
There was a recent buildbot failure on test_lock_conflict() because of a race. Looking at your patch, I must be missing something, but why not simply use a multiprocessing condition to signal when the parent process has acquired the lock? Otherwise you could simply use a pipe or a socketpair, it would be much simpler. Also, there's a race: if the parent process calls connect() before the child calls listen(), he'll get ECONNREFUSED.

Content

There was a recent buildbot failure on test_lock_conflict() because of a race.
Looking at your patch, I must be missing something, but why not simply use a multiprocessing condition to signal when the parent process has acquired the lock?
Otherwise you could simply use a pipe or a socketpair, it would be much simpler.
Also, there's a race: if the parent process calls connect() before the child calls listen(), he'll get ECONNREFUSED.

History
Date	User	Action	Args
2011-12-18 12:02:16	neologix	set	recipients: + neologix, r.david.murray, sdaoden
2011-12-18 12:02:16	neologix	set	messageid: <1324209736.5.0.895749858366.issue11867@psf.upfronthosting.co.za>
2011-12-18 12:01:15	neologix	link	issue11867 messages
2011-12-18 12:01:15	neologix	create