Message 150552 - Python tracker

Message150552

Author	eric.smith
Recipients	benjamin.peterson, eric.smith, ezio.melotti, loewis, mark.dickinson, skrah, vstinner
Date	2012-01-03.22:51:26
SpamBayes Score	0.00036276534
Marked as misclassified	No
Message-id	<1325631087.53.0.921233956643.issue13706@psf.upfronthosting.co.za>
In-reply-to

Content
I assume this is left over from the PEP 393 changes. I think the right thing to do is delete this code from line 277 of formatter_unicode.c: if (format->fill_char > 127 \|\| format->align > 127 \|\| format->sign > 127) { PyErr_SetString(PyExc_ValueError, "fill character too large"); return 0; } I'm not sure such a restriction needs to exist any more. But I'll admit to not having thought it through.

Content

I assume this is left over from the PEP 393 changes. I think the right thing to do is delete this code from line 277 of formatter_unicode.c:

    if (format->fill_char > 127 || format->align > 127 ||
        format->sign > 127) {
        PyErr_SetString(PyExc_ValueError, "fill character too large");
        return 0;
    }

I'm not sure such a restriction needs to exist any more. But I'll admit to not having thought it through.

History
Date	User	Action	Args
2012-01-03 22:51:27	eric.smith	set	recipients: + eric.smith, loewis, mark.dickinson, vstinner, benjamin.peterson, ezio.melotti, skrah
2012-01-03 22:51:27	eric.smith	set	messageid: <1325631087.53.0.921233956643.issue13706@psf.upfronthosting.co.za>
2012-01-03 22:51:26	eric.smith	link	issue13706 messages
2012-01-03 22:51:26	eric.smith	create