Message 150867 - Python tracker

Message150867

Author	pitrou
Recipients	Arfrever, David.Townshend, Devin Jeanpierre, Julian, amaury.forgeotdarc, benjamin.peterson, cvrebert, docs@python, eric.araujo, neologix, pitrou, vstinner
Date	2012-01-08.14:36:57
SpamBayes Score	1.4872526e-07
Marked as misclassified	No
Message-id	<1326033418.04.0.645986399942.issue12760@psf.upfronthosting.co.za>
In-reply-to

Content
I don't think the "created()" method has to be exposed. People can inspect the "mode" attribute if they want to have that information. (besides, the semantics are misleading since a new file opened with "w" has also be created, but created() would return False) There's some bogus indentation in the patch (it uses tab characters in some places). Also: + if not (creating + reading or writing or appending): Not sure why the "+". Shouldn't it be "or" instead?

Content

I don't think the "created()" method has to be exposed. People can inspect the "mode" attribute if they want to have that information.
(besides, the semantics are misleading since a new file opened with "w" has also be created, but created() would return False)

There's some bogus indentation in the patch (it uses tab characters in some places).

Also:

+    if not (creating + reading or writing or appending):

Not sure why the "+". Shouldn't it be "or" instead?

History
Date	User	Action	Args
2012-01-08 14:36:58	pitrou	set	recipients: + pitrou, amaury.forgeotdarc, vstinner, benjamin.peterson, Devin Jeanpierre, eric.araujo, Arfrever, cvrebert, neologix, docs@python, Julian, David.Townshend
2012-01-08 14:36:58	pitrou	set	messageid: <1326033418.04.0.645986399942.issue12760@psf.upfronthosting.co.za>
2012-01-08 14:36:57	pitrou	link	issue12760 messages
2012-01-08 14:36:57	pitrou	create