Message154847
| Author | pitrou |
|---|---|
| Recipients | alexandre.vassalotti, pitrou, sbt |
| Date | 2012-03-03.19:56:47 |
| SpamBayes Score | 2.9849449e-05 |
| Marked as misclassified | No |
| Message-id | <1330804608.5.0.444366265398.issue14166@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
That looks like a good idea. I don't understand the following code: + try: + self._dispatch_table = self.dispatch_table + except AttributeError: + self._dispatch_table = dispatch_table ... since self.dispatch_table is a property returning self._dispatch_table. Did you mean type(self).dispatch_table? Also, you need to update the docs (which will also make the intended semantics of the patch clearer :-)). |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-03-03 19:56:48 | pitrou | set | recipients: + pitrou, alexandre.vassalotti, sbt |
| 2012-03-03 19:56:48 | pitrou | set | messageid: <1330804608.5.0.444366265398.issue14166@psf.upfronthosting.co.za> |
| 2012-03-03 19:56:47 | pitrou | link | issue14166 messages |
| 2012-03-03 19:56:47 | pitrou | create | |