Message 156634 - Python tracker

Message156634

Author	Jim.Jewett
Recipients	Jim.Jewett, eric.snow, gvanrossum, vstinner
Date	2012-03-23.05:04:40
SpamBayes Score	0.00038898506
Marked as misclassified	No
Message-id	<1332479081.3.0.39400386744.issue14386@psf.upfronthosting.co.za>
In-reply-to

Content
> The problem is to reject sequence in dictproxy constructor. Why? Just because you can't delegate in quite the same way? A sequence does meet the (immutable) Mapping interface; it just won't happen to have any non-integer keys. Or are you worried about IndexError vs KeyError? Personally, I would just document it as returning LookupError, but if you're really worried, you could always catch the IndexError and raise a KeyError from it. > The "PyMapping_Check(dict) && !PyMapping_Check(dict)" I'm not seeing how anything could sanely pass that ... was there a typo when pasting?

Content

> The problem is to reject sequence in dictproxy constructor.

Why?  Just because you can't delegate in quite the same way?  A sequence *does* meet the (immutable) Mapping interface; it just won't happen to have any non-integer keys.

Or are you worried about IndexError vs KeyError?  Personally, I would just document it as returning LookupError, but if you're really worried, you could always catch the IndexError and raise a KeyError from it.

> The "PyMapping_Check(dict) && !PyMapping_Check(dict)" 

I'm not seeing how anything could sanely pass that ... was there a typo when pasting?

History
Date	User	Action	Args
2012-03-23 05:04:41	Jim.Jewett	set	recipients: + Jim.Jewett, gvanrossum, vstinner, eric.snow
2012-03-23 05:04:41	Jim.Jewett	set	messageid: <1332479081.3.0.39400386744.issue14386@psf.upfronthosting.co.za>
2012-03-23 05:04:40	Jim.Jewett	link	issue14386 messages
2012-03-23 05:04:40	Jim.Jewett	create