Message 159308 - Python tracker

Message159308

Author	pitrou
Recipients	Arfrever, brett.cannon, eric.araujo, eric.smith, eric.snow, lemburg, ncoghlan, pitrou
Date	2012-04-25.15:55:44
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1335369259.3465.7.camel@localhost.localdomain>
In-reply-to	<1335368495.19.0.618051589178.issue14657@psf.upfronthosting.co.za>

Content
> Actually, rather than a test in test suite, we would just change the > current automatic rebuild to a Modules/Setup style > "'Lib/importlib._bootstrap.py' is newer than 'Python/importlib.h', you > may need to run 'make freeze_importlib'" -1 from me. Nobody pays attention to this kind of warning. (and the Modules/Setup thing is a nuisance) Really, we must unsure that the frozen version of importlib is up-to-date. Also, normally you would write your tests in test_import, so that the builtin import is tested. So you have to regenerate importlib before committing (or you break the buildbots).

Content

> Actually, rather than a test in test suite, we would just change the
> current automatic rebuild to a Modules/Setup style
> "'Lib/importlib._bootstrap.py' is newer than 'Python/importlib.h', you
> may need to run 'make freeze_importlib'"

-1 from me. Nobody pays attention to this kind of warning.
(and the Modules/Setup thing is a nuisance)
Really, we must unsure that the frozen version of importlib is
up-to-date.
Also, normally you would write your tests in test_import, so that the
builtin import *is* tested. So you have to regenerate importlib before
committing (or you break the buildbots).

History
Date	User	Action	Args
2012-04-25 15:55:45	pitrou	set	recipients: + pitrou, lemburg, brett.cannon, ncoghlan, eric.smith, eric.araujo, Arfrever, eric.snow
2012-04-25 15:55:44	pitrou	link	issue14657 messages
2012-04-25 15:55:44	pitrou	create