Message 164982 - Python tracker

Message164982

Author	pitrou
Recipients	antlong, eric.araujo, jerub, orsenthil, pitrou, python-dev, rosslagerwall, wichert
Date	2012-07-08.09:30:31
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1341739832.34.0.366414803172.issue14826@psf.upfronthosting.co.za>
In-reply-to

Content
Senthil, do you read python-dev? I think this change was prematurate from the start (nevermind the fact that you didn't run the test suite before committing). For example, if you have an URL with a non-ASCII domain name such as "http://وزارة-الأتصالات.مصر/", the domain name should IDNA-encoded, not %-encoded like the rest. Furthermore, some people are certainly already quoting their URLs to workaround this issue, so "fixing" it will break their code by double-escaping the URLs. You've got to be more careful.

Content

Senthil, do you read python-dev? I think this change was prematurate from the start (nevermind the fact that you didn't run the test suite before committing).

For example, if you have an URL with a non-ASCII domain name such as "http://وزارة-الأتصالات.مصر/", the domain name should IDNA-encoded, not %-encoded like the rest.

Furthermore, some people are certainly already quoting their URLs to workaround this issue, so "fixing" it will break their code by double-escaping the URLs. You've got to be more careful.

History
Date	User	Action	Args
2012-07-08 09:30:32	pitrou	set	recipients: + pitrou, orsenthil, jerub, wichert, eric.araujo, antlong, rosslagerwall, python-dev
2012-07-08 09:30:32	pitrou	set	messageid: <1341739832.34.0.366414803172.issue14826@psf.upfronthosting.co.za>
2012-07-08 09:30:31	pitrou	link	issue14826 messages
2012-07-08 09:30:31	pitrou	create