Message 169472 - Python tracker

Message169472

Author	belopolsky
Recipients	belopolsky, docs@python, ncoghlan, pitrou, skrah
Date	2012-08-30.17:30:01
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1346347802.95.0.585302484332.issue15821@psf.upfronthosting.co.za>
In-reply-to

Content
I've updated test_indirect.py to print all memoryview fields and cleaned up the _testbuffer patch a little. Note this code that is needed to prevent a memory leak: + /* PyMemoryView_FromBuffer ignores info.obj. Add it explicitely. / + if (view != NULL) + ((PyMemoryViewObject )view)->view.obj = info.obj; Shouldn't PyMemoryView_FromBuffer() copy non-NULL obj from Py_buffer?

Content

I've updated test_indirect.py to print all memoryview fields and cleaned up the _testbuffer patch a little.  Note this code that is needed to prevent a memory leak:

+    /* PyMemoryView_FromBuffer ignores info.obj.  Add it explicitely. */
+    if (view != NULL)
+      ((PyMemoryViewObject *)view)->view.obj = info.obj;

Shouldn't  PyMemoryView_FromBuffer() copy non-NULL obj from Py_buffer?

History
Date	User	Action	Args
2012-08-30 17:30:02	belopolsky	set	recipients: + belopolsky, ncoghlan, pitrou, skrah, docs@python
2012-08-30 17:30:02	belopolsky	set	messageid: <1346347802.95.0.585302484332.issue15821@psf.upfronthosting.co.za>
2012-08-30 17:30:02	belopolsky	link	issue15821 messages
2012-08-30 17:30:02	belopolsky	create