Message 170909 - Python tracker

Message170909

Author	Julian
Recipients	Julian, benjamin.peterson, brett.cannon, vstinner
Date	2012-09-21.18:12:13
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1348251134.25.0.334113349049.issue15987@psf.upfronthosting.co.za>
In-reply-to

Content
I'd say yes (to both lineno/col_offset). And yeah that sounds like what I had in mind (a helper function). If I'm specific for a moment about implementation, perhaps something like `ast.diff`, which yielded tuples of differing nodes (in say, breadth first order down the tree) from two given nodes, and took args for configuration, compare_lineno and compare_col_offset (both defaulted to True), and then __eq__ was just `next(ast.diff(self, other, compare_lineno=True, compare_col_offset=True), None) is None`. Sound good to you?

Content

I'd say yes (to both lineno/col_offset). And yeah that sounds like what I had in mind (a helper function).

If I'm specific for a moment about implementation, perhaps something like `ast.diff`, which yielded tuples of differing nodes (in say, breadth first order down the tree) from two given nodes, and took args for configuration, compare_lineno and compare_col_offset (both defaulted to True), and then __eq__ was just `next(ast.diff(self, other, compare_lineno=True, compare_col_offset=True), None) is None`.

Sound good to you?

History
Date	User	Action	Args
2012-09-21 18:12:14	Julian	set	recipients: + Julian, brett.cannon, vstinner, benjamin.peterson
2012-09-21 18:12:14	Julian	set	messageid: <1348251134.25.0.334113349049.issue15987@psf.upfronthosting.co.za>
2012-09-21 18:12:13	Julian	link	issue15987 messages
2012-09-21 18:12:13	Julian	create