Message 172936 - Python tracker

Message172936

Author	roger.serwy
Recipients	fgracia, ned.deily, roger.serwy
Date	2012-10-15.01:25:36
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1350264338.36.0.653125202792.issue16226@psf.upfronthosting.co.za>
In-reply-to

Content
Here's the revision that broke it: b81ddaf0db47 The 2.7 branch still uses imp.get_suffixes, whereas the 3.3 and 3.4 uses this importlib construct. The imp.get_suffixes returns a list of tuples of 3 items: (suffix, mode, type). The current code only returns what would be the first item of that tuple. The for-loop only uses that first item anyway, so the tuple unpacking can be removed safely. The attached patch fixes the issue. It also includes a basic unit test within the idlelib/test directory. We need to get the unittest framework started for IDLE, as given in issue15392.

Content

Here's the revision that broke it: b81ddaf0db47

The 2.7 branch still uses imp.get_suffixes, whereas the 3.3 and 3.4 uses this importlib construct.

The imp.get_suffixes returns a list of tuples of 3 items: (suffix, mode, type). The current code only returns what would be the first item of that tuple. The for-loop only uses that first item anyway, so the tuple unpacking can be removed safely.


The attached patch fixes the issue. It also includes a basic unit test within the idlelib/test directory. We need to get the unittest framework started for IDLE, as given in issue15392.

History
Date	User	Action	Args
2012-10-15 01:25:38	roger.serwy	set	recipients: + roger.serwy, ned.deily, fgracia
2012-10-15 01:25:38	roger.serwy	set	messageid: <1350264338.36.0.653125202792.issue16226@psf.upfronthosting.co.za>
2012-10-15 01:25:38	roger.serwy	link	issue16226 messages
2012-10-15 01:25:37	roger.serwy	create