Message 172939 - Python tracker

Message172939

Author	jcea
Recipients	btubbs, jcea, pitrou, pje
Date	2012-10-15.02:30:36
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1350268237.43.0.893794690171.issue16220@psf.upfronthosting.co.za>
In-reply-to

Content
Your patch is trivial enough, I am OK to integrate it as is, but it would be nice to verify that we are not reintroducing this bug in the future. I know that writing a the test will be far more difficult that writing the patch. You can try :). Anyway I am OK to integrate current patch as is. Looks simple enough. The comment in "run()" is a bit scary, and we could call "self.close()" twice, with this patch, or call extra code after "self.close()" is called. I don't know it that would be an issue, I am not familiarized enough with WSGI.

Content

Your patch is trivial enough, I am OK to integrate it as is, but it would be nice to verify that we are not reintroducing this bug in the future. 

I know that writing a the test will be far more difficult that writing the patch. You can try :).

Anyway I am OK to integrate current patch as is. Looks simple enough.

The comment in "run()" is a bit scary, and we could call "self.close()" twice, with this patch, or call extra code after "self.close()" is called. I don't know it that would be an issue, I am not familiarized enough with WSGI.

History
Date	User	Action	Args
2012-10-15 02:30:37	jcea	set	recipients: + jcea, pje, pitrou, btubbs
2012-10-15 02:30:37	jcea	set	messageid: <1350268237.43.0.893794690171.issue16220@psf.upfronthosting.co.za>
2012-10-15 02:30:37	jcea	link	issue16220 messages
2012-10-15 02:30:36	jcea	create