Message177699
| Author | georg.brandl |
|---|---|
| Recipients | asvetlov, chris.jerdonek, docs@python, georg.brandl, serhiy.storchaka |
| Date | 2012-12-18.18:41:25 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1355856086.03.0.903512642.issue16714@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
LGTM, except for: diff -r 907d71668d3c Python/pythonrun.c --- a/Python/pythonrun.c Sun Dec 16 21:10:35 2012 +0100 +++ b/Python/pythonrun.c Tue Dec 18 19:35:27 2012 +0200 @@ -2518,7 +2518,7 @@ PyOS_CheckStack(void) { __try { - /* alloca throws a stack overflow exception if there's + /* alloca raises a stack overflow exception if there's not enough space left on the stack */ alloca(PYOS_STACK_MARGIN * sizeof(void*)); return 0; This is talking about a C++ exception and therefore "throw" is correct. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-12-18 18:41:26 | georg.brandl | set | recipients: + georg.brandl, asvetlov, chris.jerdonek, docs@python, serhiy.storchaka |
| 2012-12-18 18:41:26 | georg.brandl | set | messageid: <1355856086.03.0.903512642.issue16714@psf.upfronthosting.co.za> |
| 2012-12-18 18:41:25 | georg.brandl | link | issue16714 messages |
| 2012-12-18 18:41:25 | georg.brandl | create | |