Message 178727 - Python tracker

Message178727

Author	serhiy.storchaka
Recipients	amaury.forgeotdarc, brian.curtin, python-dev, serhiy.storchaka
Date	2013-01-01.09:26:50
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<201301011126.31649.storchaka@gmail.com>
In-reply-to	<3YZmWm3jrLzSBy@mail.python.org>

Content
> New changeset 3738d270c54a by Brian Curtin in branch 'default': > st_dev/st_rdev should be unsigned long as dwVolumeSerialNumber, which it is > set to, is a DWORD. This was fixed in #11939 and the overflow was > mentioned in #10657 and seen by me on some machines. > http://hg.python.org/cpython/rev/3738d270c54a But than st_dev used as long in _pystat_fromstructstat(). Perhaps you should check if st_dev is negative and then select PyLong_FromLong/PyLong_FromLongLong or PyLong_FromUnsignedLong/PyLong_FromUnsignedLongLong.

Content

> New changeset 3738d270c54a by Brian Curtin in branch 'default':
> st_dev/st_rdev should be unsigned long as dwVolumeSerialNumber, which it is
> set to, is a DWORD. This was fixed in #11939 and the overflow was
> mentioned in #10657 and seen by me on some machines.
> http://hg.python.org/cpython/rev/3738d270c54a

But than st_dev used as long in _pystat_fromstructstat(). Perhaps you should 
check if st_dev is negative and then select 
PyLong_FromLong/PyLong_FromLongLong or 
PyLong_FromUnsignedLong/PyLong_FromUnsignedLongLong.

History
Date	User	Action	Args
2013-01-01 09:26:51	serhiy.storchaka	set	recipients: + serhiy.storchaka, amaury.forgeotdarc, brian.curtin, python-dev
2013-01-01 09:26:51	serhiy.storchaka	link	issue11939 messages
2013-01-01 09:26:50	serhiy.storchaka	create