Message 179429 - Python tracker

Message179429

Author	sanyi
Recipients	sanyi
Date	2013-01-09.10:28:27
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1357727307.69.0.69749124261.issue16904@psf.upfronthosting.co.za>
In-reply-to

Content
In http.client.HTTPConnection's send(data) method if data has attribute read after is handled correctly as file-like object and sent out successfully the code continues to what should be an else branch (~line 858) and tries to send out again the data. This is harmless in most situations but only by chance and also run's unnecessary code. I propose either to use an else branch for the code after line 858 or simply instead break return at line 853. Cheers, Sanyi

Content

In http.client.HTTPConnection's send(data) method if data has attribute read after is handled correctly as file-like object and sent out successfully the code continues to what should be an else branch (~line 858) and tries to send out again the data. This is harmless in most situations but only by chance and also run's unnecessary code.

I propose either to use an else branch for the code after line 858 or simply instead break return at line 853.

Cheers,
Sanyi

History
Date	User	Action	Args
2013-01-09 10:28:27	sanyi	set	recipients: + sanyi
2013-01-09 10:28:27	sanyi	set	messageid: <1357727307.69.0.69749124261.issue16904@psf.upfronthosting.co.za>
2013-01-09 10:28:27	sanyi	link	issue16904 messages
2013-01-09 10:28:27	sanyi	create