Message 189252 - Python tracker

Message189252

Author	eric.araujo
Recipients	eric.araujo, ezio.melotti, jdennis, r.david.murray
Date	2013-05-14.22:10:00
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1368569400.23.0.663127540559.issue16611@psf.upfronthosting.co.za>
In-reply-to

Content
I have just been bitten by a bug (haven’t checked if it’s covered by the added tests) where Cookies uses string.translate incorrectly: File "/usr/lib/python2.7/Cookie.py", line 323, in _quote if "" == translate(str, idmap, LegalChars): File "/usr/lib/python2.7/string.py", line 493, in translate return s.translate(table, deletions) TypeError: translate() takes exactly one argument (2 given) The state of the Cookie module is quite embarrassing.

Content

I have just been bitten by a bug (haven’t checked if it’s covered by the added tests) where Cookies uses string.translate incorrectly:

  File "/usr/lib/python2.7/Cookie.py", line 323, in _quote
    if "" == translate(str, idmap, LegalChars):
  File "/usr/lib/python2.7/string.py", line 493, in translate
    return s.translate(table, deletions)
TypeError: translate() takes exactly one argument (2 given)

The state of the Cookie module is quite embarrassing.

History
Date	User	Action	Args
2013-05-14 22:10:00	eric.araujo	set	recipients: + eric.araujo, ezio.melotti, r.david.murray, jdennis
2013-05-14 22:10:00	eric.araujo	set	messageid: <1368569400.23.0.663127540559.issue16611@psf.upfronthosting.co.za>
2013-05-14 22:10:00	eric.araujo	link	issue16611 messages
2013-05-14 22:10:00	eric.araujo	create