Message189778
| Author | vinay.sajip |
|---|---|
| Recipients | barry, giampaolo.rodola, maker, pitrou, r.david.murray, terry.reedy, vinay.sajip |
| Date | 2013-05-21.19:07:24 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1369163244.65.0.723699465396.issue11959@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
I wasn't suggesting changing the signature of create_socket, I just thought that it needed to be reimplemented because it didn't pass a map to set_socket. I've had a look at it again, and a reimplementation of create_socket doesn't seem to be needed, after all, because: SMTPServer.__init__ can pass the map it received to dispatcher.__init__, which will cause it to be set in self._map. Then, when create_socket calls set_socket with no map, that will call add_channel with map=None, which will then cause self._map to be used. I'll update the patch as soon as I get a chance. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-05-21 19:07:24 | vinay.sajip | set | recipients: + vinay.sajip, barry, terry.reedy, pitrou, giampaolo.rodola, r.david.murray, maker |
| 2013-05-21 19:07:24 | vinay.sajip | set | messageid: <1369163244.65.0.723699465396.issue11959@psf.upfronthosting.co.za> |
| 2013-05-21 19:07:24 | vinay.sajip | link | issue11959 messages |
| 2013-05-21 19:07:24 | vinay.sajip | create | |