Message 195730 - Python tracker

Message195730

Author	vstinner
Recipients	christian.heimes, neologix, pitrou, sbt, vstinner
Date	2013-08-20.23:46:40
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1377042401.07.0.127898528473.issue18747@psf.upfronthosting.co.za>
In-reply-to

Content
openssl_prng_atfork5.patch: - you should use RAND_pseudo_bytes() instead of RAND_bytes() in the unit test, to not skip the test depending on the entropy - the change in Misc/NEWS is strange - please remove dead code ("#if 0") - PySSL_RAND_atfork_child() comment is wrong, it is no more able to get time with a nanosecond resolution (write "(microseconds or seconds)") - can you explain the choice of "char stack[72]" (72 bytes): why no more, why not less?

Content

openssl_prng_atfork5.patch:

- you should use RAND_pseudo_bytes() instead of RAND_bytes() in the unit test, to not skip the test depending on the entropy
- the change in Misc/NEWS is strange
- please remove dead code ("#if 0")
- PySSL_RAND_atfork_child() comment is wrong, it is no more able to get time with a nanosecond resolution (write "(microseconds or seconds)")
- can you explain the choice of "char stack[72]" (72 bytes): why no more, why not less?

History
Date	User	Action	Args
2013-08-20 23:46:41	vstinner	set	recipients: + vstinner, pitrou, christian.heimes, neologix, sbt
2013-08-20 23:46:41	vstinner	set	messageid: <1377042401.07.0.127898528473.issue18747@psf.upfronthosting.co.za>
2013-08-20 23:46:41	vstinner	link	issue18747 messages
2013-08-20 23:46:40	vstinner	create