Message 198203 - Python tracker

Message198203

Author	scoder
Recipients	eli.bendersky, ncoghlan, scoder, serhiy.storchaka
Date	2013-09-21.14:14:17
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1379772858.05.0.70467032104.issue18990@psf.upfronthosting.co.za>
In-reply-to

Content
> Unfortunately I don't have time to review refactoring patches now. In light of a larger refactoring planned in this part of the module in the future, I don't think it's very important to tweak things right now. You misunderstood. The proposal was to remove the ".root" attribute, because it introduces a new API that hinders the future development and unnecessarily introduces an unprecedented inconsistency with existing APIs. This is not a refactoring.

Content

> Unfortunately I don't have time to review refactoring patches now. In light of a larger refactoring planned in this part of the module in the future, I don't think it's very important to tweak things right now.

You misunderstood. The proposal was to remove the ".root" attribute, because it introduces a new API that hinders the future development and unnecessarily introduces an unprecedented inconsistency with existing APIs.

This is not a refactoring.

History
Date	User	Action	Args
2013-09-21 14:14:18	scoder	set	recipients: + scoder, ncoghlan, eli.bendersky, serhiy.storchaka
2013-09-21 14:14:18	scoder	set	messageid: <1379772858.05.0.70467032104.issue18990@psf.upfronthosting.co.za>
2013-09-21 14:14:18	scoder	link	issue18990 messages
2013-09-21 14:14:17	scoder	create